Makefile: date format of log should not show signatures #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znewman01
previously approved these changes
Mar 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
- Coverage 29.51% 29.47% -0.04%
==========================================
Files 151 151
Lines 9666 9678 +12
==========================================
Hits 2853 2853
- Misses 6374 6386 +12
Partials 439 439 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
if user's have git configurations like `git config --global log.showSignature=true`
it will cause an issue in the Makefile variable output, like:
```shell
vbatts@possibly:~/src/github.com/sigstore/cosign$ make
[288/1916] /bin/sh: 1: Syntax error: "(" unexpected
CGO_ENABLED=0 go build -trimpath -ldflags "-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=v2.0.0-63-ge71faa1a -X sigs.k8s.io/release-utils/version.gitCommit=e71faa1af0383d860481f569ef2c01694d37b00b -X sigs.k8s.io/release-utils/version.gitTreeState="clean" -X sigs.k8s.io/release-utils/version.buildDate=" -o cosign ./cmd/cosign
```
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
quiet_log_output
branch
from
03b2c61
to
2ed0492
Compare
|
updated PTAL |
znewman01
approved these changes
Mar 25, 2023
cpanato
approved these changes
Mar 25, 2023
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 27, 2023
* Makefile: date format of log should not show signatures Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> * Makefile: add the ability to DEBUG the `make` build Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> --------- Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 27, 2023
* Makefile: date format of log should not show signatures Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> * Makefile: add the ability to DEBUG the `make` build Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> --------- Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 27, 2023
* Makefile: date format of log should not show signatures Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> * Makefile: add the ability to DEBUG the `make` build Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> --------- Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if user's have git configurations like
git config --global log.showSignature=trueit will cause an issue in the Makefile variable output, like:Fixes #2834
Now it runs clean if this corner case happens:
Release Note
Documentation